Test for phase techs' tech requirements in Structure Tree
ClosedPublic
Actions

Authored by s0600204 on May 14 2017, 10:06 PM.

Details

Reviewers

elexis

Commits

rP19585: Add missing check of phase techs' tech requirements in Structure Tree.

Summary

A bug revealed by rP19569, the tech requirements of phase techs are not checked in the structree.

Thus, the civic centres of all civs currently have the athen-specific and the generic phase techs listed side-by-side.

This patch resolves that.

Test Plan

Run 0ad and open the structree. Each civ centre should now have the correct phase techs displayed, and only the correct phase techs displayed.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

s0600204 created this revision.May 14 2017, 10:06 PM

elexis added a reviewer: elexis.May 14 2017, 10:09 PM

This is correct, because reqs is assigned the return value of DeriveTechnologyRequirements which returns the value of InterpretTechRequirements which is false if the civ cannot research the tech.
Thanks to #3993 this was quick to lookup and we didn't have to deal with specific AI or tech tree parsing code :-)
This extension should also make the tech tree more suitable to mods.

This revision is now accepted and ready to land.May 14 2017, 11:33 PM

Great patch, I'm working on the tree right now and this solved one of my problems.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1204/ for more details.

Harbormaster completed remote builds in B1723: Diff 1927.May 15 2017, 12:46 AM

Closed by commit rP19585: Add missing check of phase techs' tech requirements in Structure Tree. (authored by s0600204). · Explain WhyMay 15 2017, 8:56 PM

This revision was automatically updated to reflect the committed changes.

elexis mentioned this in rP19569: Make phase technology researchable in all captured civic center. Reviewed by….Jul 9 2017, 1:52 AM