In D5020#213870, @Freagarach wrote:

This doesn't seem to give the same result when we have another entity with preference 0, but I guess that is kind of undefined anyway. ^^

As far as I know we either return the entities in either sorted-by-distance or random-order from the range manager, so this should be 'good enough still'.

Yeah, indeed.

binaries/data/mods/public/simulation/components/UnitAI.js
6442 ↗	(On Diff #21847)	I don't think this line adds much in the long run? But meh. :)

wraitii added inline comments.Jun 2 2023, 8:17 AM

binaries/data/mods/public/simulation/components/UnitAI.js
6442 ↗	(On Diff #21847)	If we ever change the preferences to target a 'less common' class first it might be a performance problem, which is what I kinda dislike about this optimisation though it's a huge speed boost.

Guess what, this doesn't actually change hashes on CombatDemoHuge because we always short-circuit.
It's probably the single biggest improvement we've ever had on that particular map.

Note quite 'playable' just yet, but it's getting closer.

In D5020#213981, @wraitii wrote:

Guess what, this doesn't actually change hashes on CombatDemoHuge because we always short-circuit.
It's probably the single biggest improvement we've ever had on that particular map.

Do you have not logarithmic but linear per-turn stats?

In D5020#214028, @vladislavbelov wrote:

In D5020#213981, @wraitii wrote:

Guess what, this doesn't actually change hashes on CombatDemoHuge because we always short-circuit.
It's probably the single biggest improvement we've ever had on that particular map.

Do you have not logarithmic but linear per-turn stats?

Those graphs aren't logarithmic, they're using an updated Profiler2. On average, frames with the patch take literally 2x less time.

real_tabasco_sauce added a subscriber: real_tabasco_sauce.Jun 5 2023, 11:54 PM

real_tabasco_sauce added inline comments.

binaries/data/mods/public/simulation/components/UnitAI.js
6442 ↗	(On Diff #21847)	Would ships then be be less performant if they attacked with unitAI? I guess there won't be as many ships as soldiers typically, so in that case its likely still better.

wraitii added inline comments.Jun 6 2023, 8:45 AM

binaries/data/mods/public/simulation/components/UnitAI.js
6442 ↗	(On Diff #21847)	Mh, guess the comment is unclear. The reason this is an optimisation is that regular units usually are around 'Human' units, and so there usually is one around them. So they can use this short-circuit. Ships are similar: their first preference is 'Ship', which is what usually will be around them. So they will benefit from this optimisation in general. Furthermore, this doesn't really slow down the code in case there are no such units around, since it's just as simpl 'if', so it's basically a free win.