Page MenuHomeWildfire Games

Removed space in filename of track 'Karmic Confluence'
ClosedPublic

Authored by Phormio on May 16 2017, 4:27 PM.

Details

Summary

Spaces in filenames suck, and this is the only sound file that has one.

But mostly, this differential is an exercise for D507, where I got work to do.

Test Plan

Not applicable.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Phormio created this revision.May 16 2017, 4:27 PM
elexis added a subscriber: elexis.May 16 2017, 4:30 PM

Then you must edit all places that hardcode this filename too. The civ json for example.

In D508#20458, @elexis wrote:

Then you must edit all places that hardcode this filename too. The civ json for example.

Okay.

Phormio updated this revision to Diff 1975.May 16 2017, 4:47 PM
  • updated file referencing old filename
vladislavbelov accepted this revision.May 20 2017, 6:38 PM
vladislavbelov added a subscriber: vladislavbelov.

I didn't find any other occurrences of this file. All music files have underscores in their names instead of spaces. But there're template files which have spaces. So it could be fixed too, in other patch of course.

This revision is now accepted and ready to land.May 20 2017, 6:38 PM
elexis accepted this revision.May 21 2017, 12:55 AM
This revision was automatically updated to reflect the committed changes.