Some fixes for D194
Details
Details
- Reviewers
Itms - Commits
- rP19628: fixes to the economic tutorial (D194) following rP19599
check that the issue mentionned in rP19599 is solved
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
binaries/data/mods/public/gui/gamesetup/gamesetup.js | ||
---|---|---|
1784 ↗ | (On Diff #2026) | not really needed at present, but would be necessary if the tutorial map would have some own settings (as starting resource). |
binaries/data/mods/public/maps/tutorials/starting_economy_walkthrough.xml | ||
50 ↗ | (On Diff #2026) | old map comment which does not apply anymore with triggers |
binaries/data/mods/public/maps/tutorials/starting_economy_walkthrough.js | ||
---|---|---|
52 ↗ | (On Diff #2026) | Either "change" or "that the cursor changes" (note the "that"). |
binaries/data/mods/public/maps/tutorials/starting_economy_walkthrough.js | ||
---|---|---|
52 ↗ | (On Diff #2026) | thanks :) |
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/1253/ for more details.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/1255/ for more details.
binaries/data/mods/public/maps/scripts/Tutorial.js | ||
---|---|---|
93 ↗ | (On Diff #2049) | these are in fact useless (leftover of previous iterations) and can be removed |
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/1268/ for more details.