Page MenuHomeWildfire Games

fixes to the economic tutorial (D194) following rP19599
ClosedPublic

Authored by mimo on May 19 2017, 6:48 PM.

Details

Summary

Some fixes for D194

Test Plan

check that the issue mentionned in rP19599 is solved

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1804
Build 2857: Vulcan BuildJenkins
Build 2856: arc lint + arc unit

Event Timeline

mimo created this revision.May 19 2017, 6:48 PM
Owners added a subscriber: Restricted Owners Package.May 19 2017, 6:48 PM
mimo added inline comments.May 19 2017, 6:52 PM
binaries/data/mods/public/gui/gamesetup/gamesetup.js
1784

not really needed at present, but would be necessary if the tutorial map would have some own settings (as starting resource).

binaries/data/mods/public/maps/tutorials/starting_economy_walkthrough.xml
50

old map comment which does not apply anymore with triggers

leper added a subscriber: leper.
leper added inline comments.
binaries/data/mods/public/maps/tutorials/starting_economy_walkthrough.js
52

Either "change" or "that the cursor changes" (note the "that").

mimo added inline comments.May 19 2017, 7:17 PM
binaries/data/mods/public/maps/tutorials/starting_economy_walkthrough.js
52

thanks :)

Vulcan added a subscriber: Vulcan.May 19 2017, 8:00 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1253/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1255/ for more details.

mimo updated this revision to Diff 2049.May 20 2017, 6:38 PM

remove useless stuff

mimo added inline comments.May 20 2017, 6:40 PM
binaries/data/mods/public/maps/scripts/Tutorial.js
93 ↗(On Diff #2049)

these are in fact useless (leftover of previous iterations) and can be removed

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1268/ for more details.

Itms accepted this revision.May 21 2017, 9:41 AM

Perfect! Thanks ?

This revision is now accepted and ready to land.May 21 2017, 9:41 AM
This revision was automatically updated to reflect the committed changes.