Page MenuHomeWildfire Games

improved footprint sizes for various animals.
AbandonedPublic

Authored by Phormio on May 21 2017, 3:01 PM.

Details

Reviewers
elexis
bb
Summary

Improved footprint sizes for various animals. For each there is a picture below,
with an upper row showing the old footprint and the lower row showing the new footprint.
Atlas reloads templates when their files are written while a simulaton is running. This helped to arrange the screenshots.

Footprints from left to right have the following orientations (y values): -1, 3, 0, 1.5

  • bear footprint has now width 4.5 (previously 2), depth 7 (previously 4):

  • boar footprint has now width 3.1 (previously 2), depth 4.3 (previously 2):

  • chicken footprint has now width 1.3 (previously 0.9), depth 1.5 (previously 1.8):

  • lion footprint has now width 2.9 (previously 2), depth 5.7 (previously 4):

  • lioness footprint has now width 2.9 (previously 2), depth 5.7 (previously 4):

  • muskox footprint has now width 3.4 (previously 2.1), depth 5.8 (previously 4.2):

  • peacock footprint has now width 1.8 (previously 1.75), depth 2.4 (previously 3.5), height 3.5 (previously 2.25):

  • pig footprint has now width 2.9 (previously 1.4), depth 4.6 (previously 2.8):

  • rabbit footprint has now width 1.4 (previously 0.8), depth 1.7 (previously 1.6):

Test Plan

Changes were tested locally.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Phormio created this revision.May 21 2017, 3:01 PM
Phormio edited the summary of this revision. (Show Details)May 21 2017, 3:04 PM

I won't comment the patch itself nor review, but take care to check what the footprint is used for.
For example it's used in the Damage code: an entity gets damage when the projectile hits its footprint. So you need to check that it's visually acceptable.

bb requested changes to this revision.Sep 24 2017, 3:45 PM
bb added a subscriber: bb.

besides the the footprint changes you also changed a couple health and xp and stuff, imo they are out of scope and are better split to a balancing proposal.

Some other units that can use a check: flaming pig (should be same as normal pig, too big), wolves (all types should all be the same, too small)

Regarding the heights, they should be the vertical height in meters of the entity from the ground (regarding the definition in CCmpFootprint.cpp), however they are unused for now, so imo, we should either change nothing or change all to the height the models have (taking a male unit as ~2m)

./binaries/data/mods/public/simulation/templates/gaia/fauna_bear.xml
13

Too big imo, the footprint should really be just the place were arrows would land and hit the entity. Marking all below I find to big, sometimes even the old values were probably ok already

14

more like 3 imo

./binaries/data/mods/public/simulation/templates/gaia/fauna_boar.xml
14

more like 2

./binaries/data/mods/public/simulation/templates/gaia/fauna_chicken.xml
4

too big

./binaries/data/mods/public/simulation/templates/gaia/fauna_lion.xml
27–29

notice this is also broken (test atlas) (couldn't test due to that)

./binaries/data/mods/public/simulation/templates/gaia/fauna_lioness.xml
27–29

same here

./binaries/data/mods/public/simulation/templates/gaia/fauna_muskox.xml
4

too big

./binaries/data/mods/public/simulation/templates/gaia/fauna_peacock.xml
10

too big

11

height tags have been found unused in the current code, but setting one to something unrandom is fine

./binaries/data/mods/public/simulation/templates/gaia/fauna_pig.xml
10

too big

./binaries/data/mods/public/simulation/templates/gaia/fauna_rabbit.xml
4

Too big, but were already changed also

This revision now requires changes to proceed.Sep 24 2017, 3:45 PM
Nescio abandoned this revision.Aug 15 2020, 3:27 PM

This patch is outdated, incomplete, and superfluous because of the more recent D2721/rP23930.