Page MenuHomeWildfire Games

Fix sound xml files which doesn't validate
ClosedPublic

Authored by fatherbushido on May 21 2017, 6:00 PM.

Details

Reviewers
Phormio
Summary

Complete, checked with validate.pl
The missing peacock sound is reported in ticket #4586.

Test Plan

-

Event Timeline

fatherbushido created this revision.May 21 2017, 6:00 PM

remove artefacts

Phormio accepted this revision.May 21 2017, 6:52 PM
This revision is now accepted and ready to land.May 21 2017, 6:52 PM
Vulcan added a subscriber: Vulcan.May 21 2017, 8:23 PM

Build is green

Executing section Default...
Executing section Source...
Executing section JS...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/3/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1286/ for more details.

Build is green

Executing section Default...
Executing section Source...
Executing section JS...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/4/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1287/ for more details.

@Phormio: can you quickly describe why you accept it?

@Phormio: can you quickly describe why you accept it?

The patch fixed minor syntax errors and did not introduce any new errors.

The patch fixed minor syntax errors and did not introduce any new errors.

ticket for missing sound files: #4586

Phormio edited the summary of this revision. (Show Details)May 22 2017, 1:07 PM