Differential D5321

Reduce time needed for STUN
AbandonedPublic
Actions

Authored by Dunedan on Aug 13 2024, 8:33 AM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Summary

In my tests this reduced the time necessary for starting to host a game or joining a hosted game by ~180ms.

Test Plan

Test that hosting and joining games with STUN still works reliable and that it's faster than before.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 23251
Build 57223: Vulcan Build	Jenkins
Build 57222: Vulcan Build (macOS)	Jenkins
Build 57221: Vulcan Build (Windows)	Jenkins

Event Timeline

Dunedan created this revision.Aug 13 2024, 8:33 AM

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
fatal error: malformed or corrupted AST file: 'could not find file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/mozilla/Compiler.h' referenced by AST file 'obj/network_Debug/precompiled.h.gch''
1 error generated.
make[1]: *** [obj/network_Debug/StunClient.o] Error 1
make: *** [network] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7983/display/redirect

Dunedan published this revision for review.Aug 13 2024, 8:36 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/9059/display/redirect

Stan added a subscriber: Stan.Aug 13 2024, 8:39 AM

Stan added inline comments.

source/network/StunClient.cpp
186	Does that explain the 180ms speedup?
365	You should create those values in default.cfg ;)

Looks like that would need an update of default.cfg

Harbormaster completed remote builds in B23250: Diff 23322.Aug 13 2024, 8:50 AM

Update default.cfg

source/network/StunClient.cpp
186	Yes, in my tests it usually worked with the first or second try, so after 10ms or 20ms.

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
fatal error: malformed or corrupted AST file: 'could not find file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/mozilla/Compiler.h' referenced by AST file 'obj/network_Debug/precompiled.h.gch''
1 error generated.
make[1]: *** [obj/network_Debug/StunClient.o] Error 1
make: *** [network] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7984/display/redirect

Dunedan marked an inline comment as done.Aug 13 2024, 8:53 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/9060/display/redirect

Harbormaster completed remote builds in B23251: Diff 23323.Aug 13 2024, 9:07 AM

This patch is now continued as https://gitea.wildfiregames.com/0ad/0ad/pulls/6953.