Page MenuHomeWildfire Games

renamed 'Snow Wolf' to 'Arctic Wolf', renamed wolf template for consistency with other template names
ClosedPublic

Authored by Phormio on May 22 2017, 12:08 AM.

Details

Summary

The 'snow wolf' does not exist, its correct name is 'arctic wolf'. As the
only wolf with white fur, it does not live outside Canada and Greenland. I don't
object to placing it on snow, it's no less wrong than Baobabs in Turkey
(skirmish map 'Zagros Mountains (2)') or Zebras at the Caspian sea (skirmish map
'Caspian Sea (2v2)').

The PNG file contained an exif string referencing the 'snow wolf', a leftover from Photoshop.
The other changes should be straightforward.

This patch overlaps with D525, ideally those changes would be comitted first.

Test Plan

Changes were tested locally.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Phormio created this revision.May 22 2017, 12:08 AM
Owners added subscribers: Restricted Owners Package, Restricted Owners Package.May 22 2017, 12:08 AM
Phormio updated this revision to Diff 2222.May 26 2017, 5:24 PM
  • included changes to file 'polar_sea_triggers.js', which were missing previously

Filenames seem to look more like:
"animal_species" than "species_animal".
It will be "wolf_arctic" for all the filenames.

binaries/data/mods/public/maps/random/mediterranean.js
140 ↗(On Diff #2222)

Idk if this is done on purpose.
Maybe we shouldn't have berries in snow.

binaries/data/mods/public/simulation/templates/template_unit_fauna_wild_aggressive_wolf.xml
1 ↗(On Diff #2222)

This file can't be moved in templates/gaia?

Polakrity added inline comments.Jun 7 2017, 1:01 PM
binaries/data/mods/public/art/actors/fauna/arctic_wolf.xml
9 ↗(On Diff #2222)

space

12 ↗(On Diff #2222)

space

13 ↗(On Diff #2222)

unneeded space

16 ↗(On Diff #2222)

unneeded space

bb accepted this revision.Dec 26 2017, 6:30 PM
bb added a subscriber: bb.

arctic wolf indeed the correct term
some maps have been removed => ignoring

propsetting while committing

maps still load, wolves still attack

binaries/data/mods/public/art/actors/fauna/arctic_wolf.xml
16 ↗(On Diff #2222)

all fixed

binaries/data/mods/public/art/textures/ui/session/portraits/gaia/fauna_zebra.png
1 ↗(On Diff #2222)

why was this added? and what is changed?
ignoring it

binaries/data/mods/public/maps/random/northern_lights.js
394 ↗(On Diff #2222)

(not fixing whitespaces)

binaries/data/mods/public/maps/skirmishes/Dueling Cliffs (3v3).xml
15217 ↗(On Diff #2222)

(arc patch doesn't like whitespace...)

binaries/data/mods/public/simulation/templates/template_unit_fauna_wild_aggressive_wolf.xml
1 ↗(On Diff #2222)

"can" is a different store, but it shouldn't as it is a parent template

This revision is now accepted and ready to land.Dec 26 2017, 6:30 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Dec 26 2017, 10:22 PM