Cleanup the current code with Coding Conventions standard.
The file is old and he is mentioned some TODOs which have for the most been implanted.
Details
Details
- Reviewers
bb
Check if it doesn't breaks anything.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 1871 Build 2964: Vulcan Build Jenkins
Event Timeline
Comment Actions
Build has FAILED
Link to build: http://jw:8080/job/phabricator/1296/
See console output for more information: http://jw:8080/job/phabricator/1296/console
Comment Actions
didn't check for completeness because there was no context.
| ProductionQueue.js | ||
|---|---|---|
| 51 | cap | |
| 61 | cap | |
| 86 | make them proper JSdoc: @return {array} - List of entities that can be trained by this building. Same for some below | |
| 111 | ok, but not necessary, codebase is a mess on these | |
| 114 | e => ent | |
| 140 | JSdocs | |
| 164 | inline seems meh => ok | |
| 248 | make it a bit descriptive or remove | |
| 254 | implemented ok | |
| 255–256 | not done for pop cap, but ok | |
| 267 | i guess !requiredXp (otherwise ignore the jshint error and leave as if) | |
| 289 | why that cheatmultiplier? | |
| 303–311 | better keep it alphabetical order | |
| 311 | trailling comma | |
| 318 | nope, leave as is | |
| 327 | same | |
| 329 | same*2 | |
| 342 | old comment was better imo | |
| 352–358 | make alphabetical | |
| 358 | trailling comma | |
| 455 | JSdoc | |
| 547 | make more descriptive | |
| 559 | -= | |
| 585 | -= -= | |
| 622 | !createdEnts.length | |
| 637 | inline | |
| 716 | no space | |
| 729 | -= | |
| 751 | after a ":" there is no need for a cap right? | |
| 787 | -= | |
| 820 | -= | |
Comment Actions
Better to separate this into several differentials and with real things to cleanup.
In any case, thank you for all your reviews @bb