Page MenuHomeWildfire Games

Add raindrops to Extinct Volcano
ClosedPublic

Authored by elexis on May 22 2017, 4:36 PM.

Details

Summary

As noticed with D535, we actually do have rain effects. Since this map claims it rains so much that the water rises, it would be coherent to also render rain.

Test Plan

Notice the raindrops disappear if the camera distances itself from the ground too much, also on the bottom half with tiny mapsizes somehow and that
we don't have a way to set the rotation in both the rmgen library and trigger scripts (since we don't have a way to get actors from the rangemanager).

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.May 22 2017, 4:36 PM
elexis edited the summary of this revision. (Show Details)May 22 2017, 4:43 PM
Vulcan added a subscriber: Vulcan.May 22 2017, 4:50 PM
Executing section Default...
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before '='.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/maps/random/extinct_volcano.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/maps/random/extinct_volcano.js
|   2|   2| 
|   3|   3| const tHillDark = "cliff volcanic light";
|   4|   4| const tHillMedium1 = "ocean_rock_a";
|   5|    |-const tHillMedium2  = "ocean_rock_b";
|    |   5|+const tHillMedium2 = "ocean_rock_b";
|   6|   6| const tHillVeryDark = ["cliff volcanic coarse", "cave_walls"];
|   7|   7| const tRoad = "road1";
|   8|   8| const tRoadWild = "road1";
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/10/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1310/ for more details.

(I didn't do any proper testing/measuring, but it seems this rain impacts performance quite a bit.)

elexis updated this revision to Diff 2173.May 24 2017, 4:33 PM

Reduced the nr of raindrop sprites a lot. Most of the time some drops are visible, sometimes not. But if the engine doesn't support it, then theres not a lot we can do easily.
The image itself might be improved perhaps. raindrop.png is only a single drop, better might be a set of textures that is animated.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1343/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before '='.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/maps/random/extinct_volcano.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/maps/random/extinct_volcano.js
|   2|   2| 
|   3|   3| const tHillDark = "cliff volcanic light";
|   4|   4| const tHillMedium1 = "ocean_rock_a";
|   5|    |-const tHillMedium2  = "ocean_rock_b";
|    |   5|+const tHillMedium2 = "ocean_rock_b";
|   6|   6| const tHillVeryDark = ["cliff volcanic coarse", "cave_walls"];
|   7|   7| const tRoad = "road1";
|   8|   8| const tRoadWild = "road1";
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/35/ for more details.

FeXoR added a reviewer: FeXoR.May 27 2017, 1:04 PM
FeXoR accepted this revision.May 27 2017, 6:56 PM

Very nice!

This revision is now accepted and ready to land.May 27 2017, 6:56 PM
Itms awarded a token.May 27 2017, 7:28 PM
This revision was automatically updated to reflect the committed changes.