Details
Details
-
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/1352/ for more details.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... binaries/data/mods/public/simulation/components/Foundation.js | 197| » » » » » » &&·(cmpOwnership.GetOwner()·==·0·||·cmpFoundationOwnership·&&·cmpOwnership.GetOwner()·==·cmpFoundationOwnership.GetOwner())) | | [NORMAL] JSHintBear: | | Misleading line break before '&&'; readers may interpret this as an expression boundary. binaries/data/mods/public/simulation/components/Foundation.js | 197| » » » » » » &&·(cmpOwnership.GetOwner()·==·0·||·cmpFoundationOwnership·&&·cmpOwnership.GetOwner()·==·cmpFoundationOwnership.GetOwner())) | | [NORMAL] JSHintBear: | | Use '===' to compare with '0'. binaries/data/mods/public/simulation/components/Foundation.js | 238| » » » var·cmpFoundationOwnership·=·Engine.QueryInterface(this.entity,·IID_Ownership); | | [NORMAL] JSHintBear: | | 'cmpFoundationOwnership' is already defined. binaries/data/mods/public/simulation/components/Foundation.js | 309| » » var·pos·=·cmpPosition.GetPosition2D(); | | [NORMAL] JSHintBear: | | 'pos' is already defined. binaries/data/mods/public/simulation/components/Foundation.js | 311| » » var·rot·=·cmpPosition.GetRotation(); | | [NORMAL] JSHintBear: | | 'rot' is already defined. Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/41/ for more details.
Comment Actions
EDIT: ah yes, we don't expect to have a negative value :p
It seems we can remove the Math.Min too
Yes it's handled in that Health function. (I noticed that in other place too, Promotion and Transform perhaps).
Comment Actions
Executing section Default... Executing section Source... Executing section JS... binaries/data/mods/public/simulation/components/Foundation.js | 339| » » » let·cmpOwnership·=·Engine.QueryInterface(this.entity,·IID_Ownership); | | [NORMAL] ESLintBear (no-shadow): | | 'cmpOwnership' is already declared in the upper scope. binaries/data/mods/public/simulation/components/Foundation.js | 197| » » » » » » &&·(cmpOwnership.GetOwner()·==·0·||·cmpFoundationOwnership·&&·cmpOwnership.GetOwner()·==·cmpFoundationOwnership.GetOwner())) | | [NORMAL] JSHintBear: | | Misleading line break before '&&'; readers may interpret this as an expression boundary. binaries/data/mods/public/simulation/components/Foundation.js | 197| » » » » » » &&·(cmpOwnership.GetOwner()·==·0·||·cmpFoundationOwnership·&&·cmpOwnership.GetOwner()·==·cmpFoundationOwnership.GetOwner())) | | [NORMAL] JSHintBear: | | Use '===' to compare with '0'. binaries/data/mods/public/simulation/components/Foundation.js | 238| » » » var·cmpFoundationOwnership·=·Engine.QueryInterface(this.entity,·IID_Ownership); | | [NORMAL] JSHintBear: | | 'cmpFoundationOwnership' is already defined. binaries/data/mods/public/simulation/components/Foundation.js | 308| » » var·pos·=·cmpPosition.GetPosition2D(); | | [NORMAL] JSHintBear: | | 'pos' is already defined. binaries/data/mods/public/simulation/components/Foundation.js | 310| » » var·rot·=·cmpPosition.GetRotation(); | | [NORMAL] JSHintBear: | | 'rot' is already defined. Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/125/ for more details.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1469/ for more details.