Currently missileHits sent before the rename but hitting the target after are lost, see #4595 for a more complete description
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
Test on the commands.txt file attached to #4595 (using the A21 version of the patch).
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 1992 Build 3199: Vulcan Build (Windows) Jenkins Build 3198: Vulcan Build Jenkins Build 3192: arc lint + arc unit
Event Timeline
Comment Actions
Executing section Default... Executing section Source... Executing section JS... binaries/data/mods/public/simulation/components/Timer.js | 63| » if·(typeof·repeattime·!=·"number"·||·!(repeattime·>·0)) | | [NORMAL] JSHintBear: | | Confusing use of '!'. Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/58/ for more details.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1376/ for more details.
Comment Actions
imo the place isn't that bad, but this can probably happen with many more functions (not that I can give examples). So shouldn't we skip the functionName check and use this for every timer function with a target (or other entity related data)? (I didn't check or test whether this crashes elsewhere in code)
| binaries/data/mods/public/simulation/components/Timer.js | ||
|---|---|---|
| 153 | remove braces while at it | |
Comment Actions
imo the place isn't that bad, but this can probably happen with many more functions (not that I can give examples). So shouldn't we skip the functionName check and use this for every timer function with a target (or other entity related data)? (I didn't check or test whether this crashes elsewhere in code)
A more generic way might work, though I'm still not sure if that logic should be in cmpTimer.
Comment Actions
I think this is a sad consequence of our architecture, but this would be awkward to put anywhere imo.
Comment Actions
(I personally think it's a bit useless, at least in that specific case, as the Damage code can handle that)
Comment Actions
Maybe fatherbushido meant that the arrow can just hit whatever entity happens to be at that location