Differential D563
Fix hero selection rings becoming unsaturated when moving Authored by Sandarac on May 28 2017, 12:30 AM.
Details When testing D432, it was noticed that hero selection overlays become unsaturated when their position changes (even if they are still selected). rP16274 introduced this bug by setting m_AlphaMin and m_Color.a to MIN_ALPHA_ALWAYS_VISIBLE needlessly if the hero moved and was still inWorld. (The selection overlay won't be rendered if m_Color.a is set to 0, saving some computations). Without the diff, move a hero around, and notice that the selection overlay becomes unsaturated while still selected (move it around with another unit as well to compare). With the diff, this should not happen. Garrison and ungarrison the hero to verify that the selection ring still disappears and reappears correctly.
Diff Detail
Event TimelineComment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files... http://jw:8080/job/phabricator/1388/ for more details. Comment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files... http://jw:8080/job/phabricator/1392/ for more details. |