The roman army camp string needed an update following D405 as reported by @Hannibal_Barca.
The other two strings use a weird phrasing IMO.
Details
Details
Grammar
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/67/ for more details.
Comment Actions
(look if it doesn't conflict with that Itms string diff)
| binaries/data/mods/public/simulation/data/auras/teambonuses/brit_player_teambonus.json | ||
|---|---|---|
| 12 ↗ | (On Diff #2263) | or 'healers of ...'? |
| binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_1.json | ||
| 3 ↗ | (On Diff #2263) | ["Structure", "Mechanical"] |
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1389/ for more details.
Comment Actions
Thanks for the review!
Doesn't.
| binaries/data/mods/public/simulation/data/auras/teambonuses/brit_player_teambonus.json | ||
|---|---|---|
| 12 ↗ | (On Diff #2263) | 5 catafalque auras and 3 civ description fields have resource cost. |
| binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_1.json | ||
| 3 ↗ | (On Diff #2263) | I could have read the aura before writing the description. I'm not going to adulterate Grugnas intention in this stringfix diff. Seems to be a very interesting naval bonus, but if used, it should be discussed whether this is a suitable and the best hero for that. |