This shows heal ranges(D432) as a circle out of pluses.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
If the auras are shown this way,maur_hero_chanakya_2.json and epic_temple_heal.json need it too (but no more than that).
What do we do to the mauryan healer who has 2 healing ranges? Leave as is (so that the config option also works as advertized)?
Comment Actions
This is good to see, it's good to have different textures for different range visualizations (although I'm a bit uncertain if this new texture should also be used for auras that happen to heal, it may be confusing to new players).
I guess this makes sense.
| binaries/data/mods/public/simulation/components/Heal.js | ||
|---|---|---|
| 92 ↗ | (On Diff #2296) | I guess a different filename should be chosen, as outline_border was used as a default, originally used exclusively for building selections. Maybe heal_overlay_range will be enough. |
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/81/ for more details.
Comment Actions
Build has FAILED
Link to build: http://jw:8080/job/phabricator/1406/
See console output for more information: http://jw:8080/job/phabricator/1406/console
| binaries/data/mods/public/simulation/components/Heal.js | ||
|---|---|---|
| 92 ↗ | (On Diff #2296) | ok, will change that, when committing. |
Comment Actions
I really like this texture for the new heal range, thanks for that (preferably just for entities with the heal component, not for healing auras).
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1435/ for more details.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/97/ for more details.