Page MenuHomeWildfire Games

Plus symbol for heal ranges
ClosedPublic

Authored by Imarok on May 28 2017, 11:46 PM.

Details

Summary

This shows heal ranges(D432) as a circle out of pluses.

Test Plan

look at temples, healers and cunobelin.
textures needs to be added manually under binaries/data/mods/public/art/textures/selection/
F146433 F146432

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
https://svn.wildfiregames.com/public/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2042
Build 3297: Vulcan Build (Windows)Jenkins
Build 3296: Vulcan BuildJenkins
Build 3295: arc lint + arc unit

Event Timeline

Imarok created this revision.May 28 2017, 11:46 PM
Owners added a subscriber: Restricted Owners Package.May 28 2017, 11:46 PM
Imarok edited the test plan for this revision. (Show Details)May 28 2017, 11:48 PM
elexis edited edge metadata.May 29 2017, 12:10 AM

If the auras are shown this way,maur_hero_chanakya_2.json and epic_temple_heal.json need it too (but no more than that).
What do we do to the mauryan healer who has 2 healing ranges? Leave as is (so that the config option also works as advertized)?

Sandarac edited edge metadata.May 29 2017, 1:29 AM

This is good to see, it's good to have different textures for different range visualizations (although I'm a bit uncertain if this new texture should also be used for auras that happen to heal, it may be confusing to new players).

In D571#23470, @elexis wrote:

What do we do to the mauryan healer who has 2 healing ranges? Leave as is (so that the config option also works as advertized)?

I guess this makes sense.

binaries/data/mods/public/simulation/components/Heal.js
92

I guess a different filename should be chosen, as outline_border was used as a default, originally used exclusively for building selections. Maybe heal_overlay_range will be enough.

Vulcan added a subscriber: Vulcan.May 29 2017, 5:02 AM
Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/81/ for more details.

Build has FAILED

Link to build: http://jw:8080/job/phabricator/1406/
See console output for more information: http://jw:8080/job/phabricator/1406/console

Imarok added inline comments.May 30 2017, 3:48 PM
binaries/data/mods/public/simulation/components/Heal.js
92

ok, will change that, when committing.

Sandarac accepted this revision.EditedMay 31 2017, 9:07 PM

I really like this texture for the new heal range, thanks for that (preferably just for entities with the heal component, not for healing auras).

This revision is now accepted and ready to land.May 31 2017, 9:07 PM
Imarok updated this revision to Diff 2358.Jun 1 2017, 5:15 PM

Remove the plus texture from temple heal aura and cunobelin heal aura

Vulcan added a comment.Jun 1 2017, 7:43 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1435/ for more details.

Vulcan added a comment.Jun 1 2017, 7:44 PM
Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/97/ for more details.

This revision was automatically updated to reflect the committed changes.