Fix a problem described by Sandarac in D545, when a non-defensive enemy structure is near one of our defensive struct, the ai constantly garrison and ungarrison units
Details
Details
- Reviewers
Sandarac - Commits
- rP19714: petra: fix an garrison/ungarrison loop due to rP19547
Test in the situation described that this does not happen anymore
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1417/ for more details.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/86/ for more details.
Comment Actions
Okay, I tested with and without the patch with this commands.txt, and it was useful to see the fix.
But I have a little concern with the comment.
| binaries/data/mods/public/simulation/ai/petra/defenseManager.js | ||
|---|---|---|
| 479 ↗ | (On Diff #2320) | I find this comment a little confusing, saying that non-defensive structure are "removed", would it be better to say instead that non-defensive structures are not considered? |
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1438/ for more details.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/100/ for more details.