Page MenuHomeWildfire Games

fixed spelling errors across 0.A.D. repository
AbandonedPublic

Authored by Phormio on Jun 2 2017, 10:22 AM.

Details

Reviewers
bb
Summary

Excluding external libraries and anything labelled third party, I changed the following spellings:

abovementioned -> above-mentioned
accout -> account
accross -> across
acount -> account
additionnal -> additional
alegiance -> allegiance
allways -> always
alway -> always
annoucement -> announcement
anway -> anyway
anywayz -> anyway
aobut -> about
arhcers -> archers
asociated -> associated
auxillary -> auxiliary
auxliliary -> auxiliary
avaliable -> available
blnder -> blender
bocking -> blocking
catergory -> category
centeral -> central
clumbs -> clumps
comparision -> comparison
comparisions -> comparisons
compler -> compiler
conviniance -> convenience
coresponding -> corresponding
criss crossing -> criss-crossing
critial -> critical
curassiers -> cuirassiers
cypess -> cypress
dangerosity -> danger
decending -> descending
deers -> deer
dependant -> dependant
descruction -> destruction
directlty -> directly
discribing -> describing
divident -> dividend
dryer -> drier
dryest -> driest
duing -> during
eachother -> each other
emporer -> emperor
enemey -> enemy
enountered -> encountered
entitites -> entities
entitys -> entities
entiy -> entity
errosion -> erosion
exlusive -> exclusive
expoent -> exponent
exsactly -> exactly
exspect -> expect
extentions -> extensions
exucute -> execute
fiercesome -> fearsome
flattenism -> flatness
Flattenism -> Flatness
focussed -> focused
gathereres -> gatherers
givven -> given
grabing -> grabbing
heigher -> higher
hiden -> hidden
hightest -> highest
hight -> height
higligth -> highlight
implemention -> implementation
inaccuray -> inaccuracy
inacessible -> inaccessible
incompleted -> unfinished
independantly -> independently
inital -> initial
inputed -> inputed
insted -> instead
inteface -> interface
interresting -> interesting
kleros -> cleros
kleruchs -> cleruchs
le'ts -> let's
loop on -> loop over
macrosity -> macros
mathmatical -> mathematical
matrixes -> matrices
may-be -> maybe
mesage -> message
mimimum -> minimum
modifs -> modifications
neccessary -> neccessary
neightbor -> neighbor
occassionally -> occasionally
occured -> occurred
occurence -> occurrence
occuring -> occurring
pacher -> packer
parethesis -> parentheses
patroling -> patrolling
perfom -> perform
plebian -> plebeian
plogon -> polygon
practised -> practiced
precense -> presence
prefered -> preferred
ptolemian -> Ptolemaic
recieved -> received
recieve -> receive
recived -> received
recusive -> recursive
refered -> referred
referring -> referring
requred -> required
ressurect -> resurrect
retreiving -> retrieving
seperated -> separated
seperate -> seperate
seperates -> separates
sheeps -> sheep
sickness -> thickness
silouette -> silhouette
smallish -> small
somehwat -> somewhat
sould -> should
specifc -> specific
squre -> square
stepness -> steepness
sucessfully -> successfully
sucessive -> successive
sucess -> success
taxture -> texture
tecnique -> technique
thermistocles -> themistocles
thoses -> those
thoughput -> throughput
transistion -> transition
tweeked -> tweaked
uncessary -> unnecessary
unecessary -> unnecessary
unneccessary -> unneccessary
untill -> until
untoucht -> untouched
uptodate -> up to date
usefull -> useful
vulerable -> vulnerable
wether -> whether

Further, all filenames including 'cypess' or 'thermistocles' were changed to 'cypress' and 'themistocles', respectively.

Test Plan

Not applicable.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2244
Build 3702: Vulcan BuildJenkins
Build 3701: arc lint + arc unit

Event Timeline

Phormio created this revision.Jun 2 2017, 10:22 AM
Owners added subscribers: Restricted Owners Package, Restricted Owners Package, Restricted Owners Package and 8 others.Jun 2 2017, 10:22 AM
Phormio updated this revision to Diff 2422.Jun 4 2017, 3:46 PM
Phormio edited the summary of this revision. (Show Details)
  • smallish -> small
Phormio updated this revision to Diff 2423.Jun 4 2017, 4:17 PM
Phormio edited the summary of this revision. (Show Details)
  • loop on -> loop over
  • may-be -> maybe
Phormio updated this revision to Diff 2425.Jun 4 2017, 5:04 PM
  • remove diff lines that result from local changes to files rather than spelling errors
Vulcan added a subscriber: Vulcan.Jun 4 2017, 6:48 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1470/ for more details.

Vulcan added a comment.Jun 4 2017, 7:36 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1471/ for more details.

Vulcan added a comment.Jun 4 2017, 9:12 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1473/ for more details.

Stan requested changes to this revision.Jun 5 2017, 4:26 PM
Stan added a reviewer: Stan.
Stan added subscribers: Itms, Stan.

Some comments keep it up :)

binaries/data/mods/public/simulation/helpers/Walls.js
37

Comments should start with caps, it's in the coding conventions AFAIK

build/premake/premake4/src/actions/make/_make.lua
39

anyone should be followed by singular so know -> knows I think.

source/gui/CDropDown.cpp
322

"try to get its closest element maybe", that's just an idea.

source/gui/CInput.h
84

Caps maybe.

source/lib/sysdep/os/linux/dir_watch_inotify.cpp
115 ↗(On Diff #2425)

Not sure about that one. Either it's an event called p, in this case pEvent can work, else it can be a ptr to an event, in which case pevent is fine or could be ptr_event or better event_ptr.

In any case I'm not sure that's a good idea to change it.

source/network/NetMessage.h
66–67

There is something fishy about inner indent here...

source/simulation2/helpers/HierarchicalPathfinder.cpp
55

Not sure about the caps to Checked here maybe @Itms had a good reason.

source/tools/profiler2/jquery-1.6.4.js
2071 ↗(On Diff #2425)

Jquery is an external library, not sure we should touch anything in it.

This revision now requires changes to proceed.Jun 5 2017, 4:26 PM
Phormio updated this revision to Diff 2451.Jun 5 2017, 7:49 PM
Phormio edited edge metadata.

follow suggestions of Stan:

  • excluded files from JQuery, a third-party library
  • removed dubious whitespace in './source/network/NetMessage.h'
  • comments begins with uppercase in './binaries/data/mods/public/simulation/helpers/Walls.js' and './source/gui/CInput.h'
  • corrected grammar mistake in './build/premake/premake4/src/actions/make/_make.lua'
  • improved wording in './source/gui/CDropDown.cpp'
  • turn boolean name Checked into lowercase in './source/simulation2/helpers/HierarchicalPathfinder.cpp' , in accordance with './source/gui/CCheckBox.cpp'
  • reverted changes to './source/lib/sysdep/os/linux/dir_watch_inotify.cpp'
Phormio edited the summary of this revision. (Show Details)Jun 5 2017, 7:51 PM
Phormio updated this revision to Diff 2452.Jun 5 2017, 8:02 PM
  • remove diff lines that result from local changes to files rather than spelling errors
Vulcan added a comment.Jun 6 2017, 2:10 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1491/ for more details.

Vulcan added a comment.Jun 6 2017, 2:58 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1492/ for more details.

Stan added a comment.Jun 8 2017, 7:28 PM

Looks okay.

Phormio updated this revision to Diff 2514.Jun 10 2017, 6:16 PM
Phormio edited the summary of this revision. (Show Details)
  • enemey -> enemy

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1530/ for more details.

Imarok added a subscriber: Imarok.Jun 15 2017, 10:54 AM

I think it would be much easier to review, if you could split this up in multiple diffs. (Like on diff for art, one for maps, one for js gui, etc.)

bb requested changes to this revision.EditedOct 21 2017, 8:30 PM
bb added a subscriber: bb.

Patch requires rebase, also splitting would be nice as mentioned but only in a slightly different way than sim/gui/art etc.

I believe the Thermistocles issues are already solved, the cypress thing should get an own patch
For the random map scripts, most of those comments are removed, if there is something left, should be splitted.
About the blnder=>blender change, isn't that something blender writes there himself? should ask an artist @Stan? Anyway split them apart.
Same goes for the <init_from> changes

The rest of the changes could stay in this revision imo

Besides that when changing a .cpp/.h file make sure to update the header year to the current

binaries/data/mods/public/simulation/components/Trigger.js
205–208

while at it add periods to the end and start a sentence with a cap (so will-> Will)

binaries/data/mods/public/simulation/data/civs/sele.json
111

translators will hate us for just changing 1 letter but we have to I guess

build/premake/premake4/tests/actions/vstudio/test_vs2010_links.lua
68

Are these function called from anywhere?

143

1 newline at end of file should stay (if phab allows us to see it...)

This revision now requires changes to proceed.Oct 21 2017, 8:30 PM
Nescio added a subscriber: Nescio.Oct 22 2017, 12:37 AM

That list of typos is really interesting. However, I fail to understand:

dependant -> dependant

(perhaps I'm blind).

practised -> practiced

Really?

neightbor -> neighbor

Instead of using American and British spellings randomly, I would personally prefer consistently using the Oxford orthography as a compromise.

Anyway, what's the policy on capitalization?

Flattenism -> Flatness
ptolemian -> Ptolemaic
thermistocles -> themistocles

Stan abandoned this revision.Dec 24 2017, 11:00 PM
Stan removed a reviewer: Stan.Dec 24 2017, 11:38 PM

It'd be better to have smaller patches for this one, as this is too big to be committed in one blow, and also to big for me to review as It touches code (Though it's only comments) I have no idea about.

elexis added a subscriber: elexis.Dec 24 2017, 11:38 PM

(Stan wanted to resign as a reviewer, the patch can be reclaimed)