Page MenuHomeWildfire Games

Always set the Seed in Gamesetup.cpp
ClosedPublic

Authored by elexis on Jun 2 2017, 5:19 PM.

Details

Summary

As covered with rP18604, the simulation should always be initialized with a Seed number (otherwise we might always get the same Regicide hero on maps with very few entities for example).
The commit didn't copy that logic change to Gamesetup.cpp which will be addressed in this patch.

Test Plan

Without this patch, the autostart on a non-random map (like pyrogenesis -autostart="scenarios/Arcadia") complains about the not specified seed and uses the default 0. With this patch, it uses the default 0 without the complaint on all maptypes.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Jun 2 2017, 5:19 PM
Vulcan added a subscriber: Vulcan.Jun 2 2017, 6:46 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1445/ for more details.

Vulcan added a comment.Jun 2 2017, 6:47 PM
Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/106/ for more details.

This revision was automatically updated to reflect the committed changes.