Clarifies input and output arguments of the rmgen2/setup.js function as in #4608. Also inlines the defaults (only occurance of defaulting in this file).
Details
Details
- Reviewers
mimo - Commits
- rP19720: Fix JSdoc, a missing explicit return, a missing warning, a typo and a jshint…
- Trac Tickets
- #4608
One could start one of _kalis maps like ambush and consult https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters or not
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Thanks for the fast fix :)
| binaries/data/mods/public/maps/random/rmgen2/setup.js | ||
|---|---|---|
| 134 ↗ | (On Diff #2380) | Choose |
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1447/ for more details.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... binaries/data/mods/public/maps/random/rmgen2/setup.js | 286| » for·(var·i·=·0;·i·<·numPlayers;·++i) | | [NORMAL] JSHintBear: | | 'i' is already defined. binaries/data/mods/public/maps/random/rmgen2/setup.js | 459| » for·(var·i·=·0;·i·<·g_MapInfo.numPlayers;·++i) | | [NORMAL] JSHintBear: | | 'i' is already defined. Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/108/ for more details.