Differential D602

tutorials not translated
ClosedPublic
Actions

Authored by mimo on Jun 4 2017, 12:14 PM.

Details

Reviewers

Itms

Commits

rP19730: fix tutorial not translated

Summary

It seems that rP19599 was not complete concerning the translations.

Test Plan

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mimo created this revision.Jun 4 2017, 12:14 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1466/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/124/ for more details.

Harbormaster completed remote builds in B2149: Diff 2414.Jun 4 2017, 1:30 PM

Tested and works. Once this is committed, the new pot file will have to be committed manually because the maintenance script will not version it automatically. If you have all the necessary stuff installed you can commit the patch and the pot file together, else I can take care of the pot file.

Once the pot file is up I will add the new resource to Transifex (that also needs to be performed manually by a maintainer of the 0ad project there).

This revision is now accepted and ready to land.Jun 4 2017, 1:41 PM

Closed by commit rP19730: fix tutorial not translated (authored by mimo). · Explain WhyJun 4 2017, 2:24 PM

This revision was automatically updated to reflect the committed changes.

In D602#24713, @Itms wrote:

Tested and works. Once this is committed, the new pot file will have to be committed manually because the maintenance script will not version it automatically. If you have all the necessary stuff installed you can commit the patch and the pot file together, else I can take care of the pot file.

Once the pot file is up I will add the new resource to Transifex (that also needs to be performed manually by a maintainer of the 0ad project there).

Thanks for the quick review. Could you also add the pot file (i've never done it, and i'm not sure i have already installed what is needed).

Uploaded the new resource in rP19731 and added it in Transifex with automatic updates set up.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

l10n/

messages.json

28 lines

Diff 2415

View Options

ps/trunk/binaries/data/mods/public/l10n/messages.json

tutorials not translatedClosedPublicActions