Differential D605
Fix a bug when attacking mirage with a range attack Authored by fatherbushido on Jun 5 2017, 2:25 PM. Tags None Referenced Files
Details
Currently when a unit attack a mirage, the projectiles are fired.
So for the moment, I suggest to just add a check for the DamageReceiver in the first step. (I have other things in mind) You can check with the attached replay as observer than the red ptol cc will get damage with the patch and not without.
Diff Detail
Event TimelineComment Actions
Comment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files... http://jw:8080/job/phabricator/1486/ for more details. Comment Actions Executing section Default...
Executing section Source...
Executing section JS...
| | [NORMAL] ESLintBear (no-multi-spaces):
| | Multiple spaces found before 'cmpAttackerOwnership'.
|----| | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/simulation/components/Damage.js
| |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/simulation/components/Damage.js
| 265| 265| Damage.prototype.TargetKilled = function(attacker, target, attackerOwner)
| 266| 266| {
| 267| 267| let cmpAttackerOwnership = Engine.QueryInterface(attacker, IID_Ownership);
| 268| |- let atkOwner = cmpAttackerOwnership && cmpAttackerOwnership.GetOwner() != -1 ? cmpAttackerOwnership.GetOwner() : attackerOwner;
| | 268|+ let atkOwner = cmpAttackerOwnership && cmpAttackerOwnership.GetOwner() != -1 ? cmpAttackerOwnership.GetOwner() : attackerOwner;
| 269| 269|
| 270| 270| // Add to killer statistics.
| 271| 271| let cmpKillerPlayerStatisticsTracker = QueryPlayerIDInterface(atkOwner, IID_StatisticsTracker);
binaries/data/mods/public/simulation/components/Damage.js
| 120| » let·cmpDamageReceiver·=·Engine.QueryInterface(data.target,·IID_DamageReceiver)
| | [NORMAL] JSHintBear:
| | Missing semicolon.
Executing section XML GUI...
Executing section Python...
Executing section Perl...http://jw:8080/job/phabricator_lint/136/ for more details. Comment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files... http://jw:8080/job/phabricator/1496/ for more details. Comment Actions Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl... http://jw:8080/job/phabricator_lint/143/ for more details. Comment Actions Currently it decreases the health of the mirage but not the original entity? Comment Actions No, because there is no DamageReceiver for the mirage.
Yes, it fix a more general issue than the Mirage thing.
I first think of things like that (getting the parent or doing thing in Mirage component) but the non-miraged entity will be caught just after in the range query. In fact that first part (check the main target could be skiped and we could only rely on the range query - wich does the DamageReceiver filtering - but it has at two inconveniences, and is out of the scope of that diff).
ok :-) | ||||||||||||||||||||||||||||||||||||||