Page MenuHomeWildfire Games

Fix percentMapExplored in the summary
AbandonedPublic

Authored by Imarok on Jun 7 2017, 8:10 PM.

Details

Reviewers
elexis
Trac Tickets
#4598
Summary

Don't use GetPercentMapExplored of the CCMpRangeManager, but use GetUnionPercentMapExplored as the former is broken, because it caches the explored counter(m_ExploredVertices) wrong. This fixes an OOS on rejoin caused by different percentMapExplored values.

Test Plan
  1. Start hosting a game on the random map anatolian plateau, tiny size, 1 player
  2. Rejoin as a late observer in a second window
  3. Wait at least 30 seconds

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
https://svn.wildfiregames.com/public/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2199
Build 3609: Vulcan Build (Windows)Jenkins
Build 3608: Vulcan BuildJenkins
Build 3607: arc lint + arc unit

Event Timeline

Imarok created this revision.Jun 7 2017, 8:10 PM
Vulcan added a subscriber: Vulcan.Jun 7 2017, 8:58 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1502/ for more details.

Vulcan added a comment.Jun 7 2017, 8:59 PM
Executing section Default...
Executing section Source...
Executing section JS...

binaries/data/mods/public/simulation/components/StatisticsTracker.js
| 306| »   if·(cmpTargetOwnership.GetOwner()·==·0)
|    | [NORMAL] JSHintBear:
|    | Use '===' to compare with '0'.
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/149/ for more details.

elexis requested changes to this revision.Jun 8 2017, 12:09 PM
elexis added a subscriber: elexis.

No cover ups

This revision now requires changes to proceed.Jun 8 2017, 12:09 PM

This will just be the emergency patch, if nobody fixes the caching.

Imarok abandoned this revision.Jun 16 2017, 2:32 PM

see above