While debugging an OOS (#4596), I encountered a case where the binary state and hash was dumped, but not the textual state. We should have a warning in case this occurs.
Details
Details
- Reviewers
vladislavbelov
- Apply this faulty patch
Index: source/simulation2/components/CCmpWaterManager.cpp =================================================================== --- source/simulation2/components/CCmpWaterManager.cpp (revision 19773) +++ source/simulation2/components/CCmpWaterManager.cpp (working copy) @@ -66,7 +66,9 @@ { Init(paramNode); - deserialize.NumberFixed_Unbounded("height", m_WaterHeight); + entity_pos_t waterHeight; + deserialize.NumberFixed_Unbounded("height", waterHeight); + SetWaterLevel(waterHeight); } virtual void HandleMessage(const CMessage& msg, bool UNUSED(global))
- Open atlas, create an extinct volcano map, save it as a scenario map.
- Change waterRiseStartTime to [0, 0] in extinct_volcano_triggers.js
- Start this scenario to produce a replay (only a second needed)
- pyrogenesis -rejointest=2 -mod=public -replay="..."
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 2279 Build 3783: Vulcan Build (Windows) Jenkins Build 3782: Vulcan Build Jenkins Build 3781: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1553/ for more details.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/194/ for more details.
Comment Actions
(I'm actually not sure about this patch anymore. I think it displays the warnings in some cases where it doesnt even intend to write the logs. I have to check again)