Fix issue in rP19732
ClosedPublic
Actions

Authored by Sandarac on Jun 15 2017, 9:02 AM.

Details

Reviewers

elexis
Itms

Commits

rP19777: Revert an unfortunate early break introduced in r19732, patch by Sandarac.

Summary

InvalidateStaticOverlay() should be called every time PositionChanged messages are sent, whether m_AlwaysVisible is true or not (instead of just breaking immediately if m_AlwaysVisible is false).

While at it, flip the selection statements so that there is only one check for msgData.inWorld.

Test Plan

Check that selection overlays still work as expected, and that hero selection overlays stay fully saturated when heroes move.
Check that the selection overlays are updated when moving buildings in atlas.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Sandarac created this revision.Jun 15 2017, 9:02 AM

Owners added a subscriber: Restricted Owners Package.Jun 15 2017, 9:02 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1559/ for more details.

Harbormaster completed remote builds in B2289: Diff 2562.Jun 15 2017, 10:13 AM

Thanks for looking into it even though I forgot to request the fix ?

This revision is now accepted and ready to land.Jun 15 2017, 7:40 PM

elexis edited the test plan for this revision. (Show Details)Jun 15 2017, 7:41 PM

Closed by commit rP19777: Revert an unfortunate early break introduced in r19732, patch by Sandarac. (authored by Itms). · Explain WhyJun 15 2017, 7:46 PM

This revision was automatically updated to reflect the committed changes.

The test plan update was a bit late but moving buildings does work with the overlays correctly moving :)