Fix foundation 6x6 and 8x8 actors.
ClosedPublic
Actions

Authored by Stan on Jun 16 2017, 8:55 PM.

Details

Reviewers

elexis
s0600204

Commits

rP20020: Fix foundation 6x6 and 8x8 actors.

Summary

as https://wildfiregames.com/forum/index.php?/topic/22474-6x6-foundation-actor-is-bugged/#comment-333015 reported those two actors are broken.

Test Plan

Construct buildings using those foundation,

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Stan created this revision.Jun 16 2017, 8:55 PM

Use the same indentation.

If you're not going to use arc, you might want to try creating patches from root directory of your working copy. Using your E drive as the root directory is not helpful.

Don't use spaces, but tabs for identation.

@Imarok XML use two spaces in most places, see what the actor editor does
@Sandarac Yeah my bad I ran svn diff a bit too high

temple mentioned this in D711: Mauryan building tweaks.Jul 5 2017, 11:16 PM

Stan added reviewers: fatherbushido, elexis.Aug 8 2017, 10:04 AM

fatherbushido removed a reviewer: fatherbushido.Aug 20 2017, 11:13 PM

The explanation on why this is broken and how it should be fixed came from @s0600204:
https://wildfiregames.com/forum/index.php?/topic/22474-6x6-foundation-actor-is-bugged/&do=findComment&comment=332998

(Stan, remind me in some weeks in case)

Looks good, and works in-game.

This revision is now accepted and ready to land.Aug 21 2017, 9:03 PM

Closed by commit rP20020: Fix foundation 6x6 and 8x8 actors. (authored by s0600204). · Explain WhyAug 21 2017, 9:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

art/

actors/

structures/

fndn_6x6.xml

66 lines

fndn_8x8.xml

82 lines

Diff 3268

View Options

ps/trunk/binaries/data/mods/public/art/actors/structures/fndn_6x6.xml