Page MenuHomeWildfire Games

After game installation there is no 0 A.D. shortcut on the desktop on windows
AbandonedPublic

Authored by Stan on Jun 18 2017, 3:33 PM.

Details

Reviewers
Vulcan
Itms
vladislavbelov
elexis
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Trac Tickets
#1637
Summary

Most of games have shortcut on the desktop.

"I think it's a good idea, the main question is where to put the option. I'm not sure we can modify the standard setup sections (Install location / Start menu folder), so we could either add a new section just for the desktop icon or hijack the "readme" option on the Finish section as described ​here (that does feel like a hack though). Either way I think it should be unchecked by default. We also need to make sure the uninstaller cleans it up correctly afterward. "

https://stackoverflow.com/questions/1517471/how-to-add-a-desktop-shortcut-option-on-finish-page-in-nsis-installer#1517851

Test Plan

Compile the installer

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 2331
Build 3875: Vulcan BuildJenkins

Event Timeline

Stan created this revision.Jun 18 2017, 3:33 PM
Stan edited the summary of this revision. (Show Details)
Vulcan edited edge metadata.Jun 18 2017, 4:20 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1581/ for more details.

vladislavbelov requested changes to this revision.Jun 25 2017, 6:45 PM
vladislavbelov added inline comments.
source/tools/dist/0ad.nsi
74

Problem is that the text won't be translated. Also the link describes the solution from 2009, but now we have NSIS 3.0.
It needs to check, is there a nonhack way?

201

Better to use upper or lower camel case like for other functions.

202

I think, it should be "$DESKTOP\0 A.D..lnk", etc. You haven't specialized the icon. Like: "$INSTDIR\foo.ico". Also I recommend to use capital letters for variables, i.e.: $DESKTOP, like for other occurrences.

This revision now requires changes to proceed.Jun 25 2017, 6:45 PM
vladislavbelov added inline comments.Jun 25 2017, 6:52 PM
source/tools/dist/0ad.nsi
248

It gives an error for me, look like it should be just:

Delete "$DESKTOP\0 A.D..lnk"
elexis resigned from this revision.Dec 12 2017, 8:22 PM
Stan abandoned this revision.Dec 12 2017, 8:45 PM