Due to swapped order of player base flattening and height area calculation woods sometimes grew into players bases. This patch fixes that.
Details
Details
- Reviewers
elexis - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP19808: Prevent height based forests to grow into player start locations.
Create several maps with this patch with different combinations of map size, number of players and seed.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Link to build: http://jw:8080/job/phabricator/1588/
See console output for more information: http://jw:8080/job/phabricator/1588/console
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/212/ for more details.
Comment Actions
To reproduce the original bug:
Generate: Map Size: Normal, Number of Players: 4, Seed: 2537 (High ground trees in bases of player 1 and 4)
Comment Actions
Build has FAILED
Link to build: http://jw:8080/job/phabricator/1589/
See console output for more information: http://jw:8080/job/phabricator/1589/console
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/213/ for more details.
Comment Actions
Change reads correct, fixes the bug reproducible with the given seen and doesn't appear to influence anything else.
| binaries/data/mods/public/maps/random/caledonian_meadows.js | ||
|---|---|---|
| 629 ↗ | (On Diff #2624) | start locations |