now that the pot files are updated, tutorials are still not translated.
This is fixed by the attached patch
Details
Details
- Reviewers
elexis - Commits
- rP19815: Tutorial still not translated. Hopefully done now!
play the tutorial in a non-english language
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Correct because markForTranslation is used (i.e. no translation context). There's no concatenation of translatable strings in starting_economy_walkthrough.js (that would break when calling translate() on that concatenation).
Complete because I've read through D194 again.
Tested by setting the language to german and passing a number of steps and warnings in the tutorial. The menu entry is translated too.
Sorry for the oversight when reviewing the patch.
Faith and prayers for this being the last iteration.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1602/ for more details.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/222/ for more details.