Page MenuHomeWildfire Games

Update AppData
ClosedPublic

Authored by Itms on Jun 27 2017, 4:06 PM.

Details

Summary

As mentioned in #3734, some fields of the appdata file (which is used for various software centers) can be corrected.

Test Plan

The specs can be found at https://www.freedesktop.org/software/appstream/docs/
Relevant are:

2.1. Generic Component
2.2. Desktop Applications

It can be validated with
appstream-util validate-strict build/resources/0ad.appdata.xml
and
appstreamcli validate build/resources/0ad.appdata.xml

The appstream version used is very crucial, as I tested with three versions and all of them complain about different things.

I'm not sure about the id and launchable tag and the filename of the desktop file.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6005
Build 10004: Vulcan BuildJenkins
Build 10003: arc lint + arc unit

Event Timeline

elexis created this revision.Jun 27 2017, 4:06 PM
Vulcan added a subscriber: Vulcan.Jun 27 2017, 4:55 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1638/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/244/ for more details.

Stan added a subscriber: Stan.Jun 27 2017, 5:09 PM

Why CC-BY-SA for the license ?

fabio added a subscriber: fabio.Jun 27 2017, 6:13 PM

You may want to update most URLs with https rather than http where available.

elexis added inline comments.Jun 27 2017, 6:49 PM
build/resources/0ad.appdata.xml
7

Notice <name> may not end with a period

elexis updated this revision to Diff 2718.Jun 27 2017, 6:59 PM

changed project and metadata license, added ssl

Validation output of AppStream CLI tool version: 0.11.0:

#W - 0ad.appdata.xml:com.wildfiregames.0ad:9
    Found invalid tag: 'launchable'. Non-standard tags must be prefixed with "x-".

Validation failed: warnings: 1

though the specs recommend that field.

fabio added a comment.Jun 27 2017, 7:12 PM

There is at least a link with http that should be changed to https (the first screenshot one).

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/246/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1641/ for more details.

elexis edited the test plan for this revision. (Show Details)Jul 2 2017, 2:25 AM
fabio added inline comments.Jul 2 2017, 11:05 AM
build/resources/0ad.appdata.xml
35–36

http -> https

elexis added a comment.Jul 2 2017, 2:46 PM

I figured that from the last comment already ;-)
What I still really would like input on would be the id and launchable field.

elexis added inline comments.Jul 12 2017, 5:40 PM
build/resources/0ad.appdata.xml
7
bb added a subscriber: bb.Dec 26 2017, 3:35 PM

Could add a release tag aswell, but needs to be updated every release ofc

build/resources/0ad.appdata.xml
7

(periods not allowed 0 A.D.?)

8

title case for Real Time Strategy Game? (maybe meh)

ngraham added inline comments.
build/resources/0ad.appdata.xml
4

This isn't a valid AppStream ID because of the zero. It would need to be com.wildfiregames._0ad, or else com.play0ad.zeroad as I suggested in D1186

Stan added a subscriber: Itms.EditedMar 16 2018, 1:00 AM

@Itms can this or D1186 be committed ?

Itms commandeered this revision.Apr 29 2018, 6:02 PM
Itms updated this revision to Diff 6495.
Itms added a reviewer: elexis.

Rebased and included D1186.

Itms planned changes to this revision.Apr 29 2018, 6:10 PM
Itms added inline comments.
build/resources/0ad.appdata.xml
41

Gnee.

Itms updated this revision to Diff 6496.Apr 29 2018, 6:20 PM

Fixed a tag, used a smaller screenshot, added Kushites.

The validation tool only complains about a missing <translation> tag but seeing the specification has a placeholder example and states it is optional, I think we don't need it.

elexis accepted this revision.Apr 29 2018, 6:43 PM

Checked all entries against the specs, reads correct.
All properties in the specs are defined, except <icon>, ⁠<releases/>, provides, requires, recommends, project_group, developer_name, translation, suggests which seem nonessential.
Still not sure if the launchable and id part is what it wants to and I didn't run the validator tool.

build/resources/0ad.appdata.xml
2–9

not sure if we need the XML comment, the url and license are present below, we could add WFG in the "developer_name" section

5

would be nice to add an atlas launchable some day

9
14

13

70

Not sure if its really intense violence "Defined as characters not easily distinguishable from reality.", maybe moderate does too

87

This section is giving me interesting ideas

This revision is now accepted and ready to land.Apr 29 2018, 6:43 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/450/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/451/display/redirect

Itms marked 3 inline comments as done.Apr 29 2018, 10:46 PM

Fixed things based on your comments, thanks! 👍

build/resources/0ad.appdata.xml
2–9

I find it nice to have such a comment, I didn't bother fixing that.

5

We have it! It's in the 0ad.desktop file.

70

Well realistic models of people die in mass, so...

I think moderate would apply to some video game with realistic graphics where one character dies in the course of a narration. This is a game centered on war otoh.

87

😆

This revision was automatically updated to reflect the committed changes.
Itms marked an inline comment as done.