When changing the sorting order, clicking on the same player again or receiving a playerlist update where the selected player has a different index in the list, the rating is loaded again from the server.
rP17924 prevented that rating reloading in case the playerlist update yielded a list where the selected player has the same index. So the check was correct, but in the wrong place.
When committing the insufficient patch, I've created a ticket for bug I was apparently aware of at the time without having figured out the trivial solution here: #3840.
When fpre implemented the nice feature in rP19287 to select the game the player is playing in when selecting a player, this bug got worse, because:
- if we first select player 1 that is playing in game 1, then game 1 is selected
- if we then select game 2 and receive a playerlist update, the currently selected player is selected again and thus game 1 is selected unintentionally.