Delete unused rubble placeholders
ClosedPublic
Actions

Authored by temple on Jun 29 2017, 3:44 AM.

Details

Reviewers

elexis

Commits

rP19859: Remove placeholder rubble templates from rP12717 which just contain a…

Summary

After D643 and D691, these rubble placeholders are no longer used.

All except rubble_3x3 used foundations instead of rubble, and rubble_stone_3x3 works for that one. The art is different between the two, but for consistency I think we should use rubble_stone_3x3. (I won't delete the associated art files.)

Test Plan

Verify (grep) that these files aren't used in any templates.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

temple created this revision.Jun 29 2017, 3:44 AM

Thanks for the patch. I've removed some files prior in the commits that removed their use. So that this patch only removes files that have been unused since introduction in #1166 / rP12717.

The patch is complete as seen by binaries/data/mods/public/simulation/templates/rubble$ grep -R fndn.
The patch is correct because grepping for the removed templates yields no results.

binaries/data/mods/public/simulation/templates/rubble/rubble_3x3.xml
4 ↗	(On Diff #2745)	It might not be used anymore as of now, but using it would be valid as it contains usable art and not a foundation! I've renamed it in rP19857. The template came from rP12719.