Page MenuHomeWildfire Games

Petra: Fix possible inconsistent response when trying to become allies
ClosedPublic

Authored by Sandarac on Jun 29 2017, 4:40 PM.

Details

Summary

When trying to become allies with an ai that has already declined a neutral request from us, the ai will respond with a "declineSuggestNeutral" chat message, which is misleading, as the ai will in fact not consider becoming neutral in that case.

Test Plan

Check that Petra responds as expected when trying to become allied/neutral.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2452
Build 4129: Vulcan BuildJenkins
Build 4128: arc lint + arc unit

Event Timeline

Sandarac created this revision.Jun 29 2017, 4:40 PM
Owners added a subscriber: Restricted Owners Package.Jun 29 2017, 4:40 PM
Vulcan added a subscriber: Vulcan.Jun 29 2017, 5:29 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1663/ for more details.

mimo accepted this revision.Jun 29 2017, 7:46 PM
This revision is now accepted and ready to land.Jun 29 2017, 7:46 PM
This revision was automatically updated to reflect the committed changes.