Differential D704
Don't early return but actually update an active query (and send the RangeUpdate message) when the query source is out of world Authored by fatherbushido on Jul 2 2017, 6:01 PM.
Details
When the source of a range aura is garrisoned, the aura effect is not updated. See #4658. (test)
There are different ways to do that change in ExecuteActiveQueries, in the patch there are minimal changes to reuse the comparaison with last queries. Suggestion are welcome. One could also argue that the change should be done in the js part and that the RangeManager has already the right behavior, but I don't think so (For example, queries are already handled in the other part of the RM for out of world source). I thought (started) to write a test but seeing that there were no unit test for any of those queries function, I gave up.
Diff Detail
Event TimelineComment Actions Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl... http://jw:8080/job/phabricator_lint/278/ for more details. Comment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files... http://jw:8080/job/phabricator/1680/ for more details. Comment Actions (High potential for abuse (applying the hero aura for the units without the hero being around, without the units being grouped by the hero range. At least one player (the one who reported it in the lobby) found out about this and the the new hero auras and global auras that changed to ranged auras, it will become a much more visible issue (which also explains why noone found it yet).)
Comment Actions (still a draft)
Comment Actions Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl... http://jw:8080/job/phabricator_lint/364/ for more details. Comment Actions Build has FAILED Updating workspaces.
Build (release)...
../../../source/simulation2/components/CCmpRangeManager.cpp: In member function ‘void CCmpRangeManager::ExecuteActiveQueries()’:
../../../source/simulation2/components/CCmpRangeManager.cpp:1125:87: error: ‘pos’ was not declared in this scope
std::stable_sort(added.begin(), added.end(), EntityDistanceOrdering(m_EntityData, pos));
^
make[1]: *** [obj/simulation2_Release/CCmpRangeManager.o] Error 1
make: *** [simulation2] Error 2
make: *** Waiting for unfinished jobs....Link to build: http://jw:8080/job/phabricator/1817/
Comment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files... http://jw:8080/job/phabricator/1826/ for more details. Comment Actions Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl... http://jw:8080/job/phabricator_lint/370/ for more details.
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||