Page MenuHomeWildfire Games

Petra: Fix bug in a case when an army captures its target and then tries to help another army
ClosedPublic

Authored by Sandarac on Jul 5 2017, 10:01 PM.

Details

Summary

When an army captures its target, it may get stuck with the captured structure as its target if it tries to update to help another army. The other plan it chooses to help may have the same target structure (and had not been updated yet), so the plan will be assigned the captured structure as a target, and it will be stuck indefinitely with the captured target.

Test Plan

See that UpdateTarget() wasn't updated for this particular case when capturing was introduced.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Sandarac created this revision.Jul 5 2017, 10:01 PM
Owners added a subscriber: Restricted Owners Package.Jul 5 2017, 10:01 PM
mimo accepted this revision.Jul 5 2017, 10:10 PM
This revision is now accepted and ready to land.Jul 5 2017, 10:10 PM
Vulcan added a subscriber: Vulcan.Jul 5 2017, 10:51 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1698/ for more details.

This revision was automatically updated to reflect the committed changes.