Mauryan building tweaks
AbandonedPublic
Actions

Authored by temple on Jul 5 2017, 11:16 PM.

Details

Reviewers: None

Summary

I've been bugged by the Mauryan house's foundation ever since I noticed that it's way too big. After playing around a bit I also noticed that their farmstead's obstruction's wrong too. So I decided to take a look at every building and see if there were adjustments that could be made.

In general I tried to match the obstruction with the visual edge of the building, and put the foundation 2m beyond that.
Some buildings have steps which can be hard to take into account, or maybe the building isn't quite centered.
Keep D651 in mind for a few of the larger foundations.

Test Plan

The structures demo map from D710 should save you some time.

See if the adjustments are reasonable.
The house foundation and farmstead obstruction are the main ones.
I don't have strong feelings about anything else, so if you want to change the numbers a bit that's probably fine with me.

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

temple created this revision.Jul 5 2017, 11:16 PM

Indeed for other civs stuff is wrong too, but I don't mind fixing few annoyances now.
The footprint should probably start exactly after the end of the model, so that the selection is as concise as possible, whereas now there is some space in there. But then again it would have to be changed for all civs.

Blacksmith footprint seems too large to me.
Def tower and gate obstruction obstruction size is slightly too small.
Wall slightly too large.

Whats up with the wonder? Its only selected when we click into the middle of it (reported a tiket about that somewhere iirc)

binaries/data/mods/public/simulation/templates/structures/maur_corral.xml
4	why? doesnt seem necessary
binaries/data/mods/public/simulation/templates/structures/maur_house.xml
16	That should be in the parent template and removed for the inherited templates

In D711#28478, @elexis wrote:

The footprint should probably start exactly after the end of the model, so that the selection is as concise as possible, whereas now there is some space in there. But then again it would have to be changed for all civs.

Note that the selection box = the bounding box, which is set by the artwork (except for fields; I didn't realize this when doing D674). I think the footprint is only used for the visual highlight and spawn points?
Probably the obstruction size should be the same as the bounding box size (at ground level)? But maybe there are exceptions. Then the footprint could be +2m from that. But some footprints are circles, while all obstructions are rectangles (for now, anyway).

(Edit: Wrote "foundation" instead of "footprint" in this paragraph.)

Whats up with the wonder? Its only selected when we click into the middle of it (reported a tiket about that somewhere iirc)

Yes, #4634. I had almost changed the foundation to 8x8 since the theatron bounding box is so small, but as soon as you start building it uses the "scaffolding" bounding box, which is also too small.
It seems there's three bounding boxes: foundation, scaffolding, completed. The scaffolding bounding box looks bad for a lot of buildings. Ideally maybe it should be the same dimensions as the completed building but at half the height, and the foundation should be the same but at some minimum height. Or maybe as the building art rises through the ground the bounding box should rise with it.

I think it probably makes more sense to go building by building rather than civ by civ. I'll do farmsteads next because the Mauryan one is so bad.