Page MenuHomeWildfire Games

Upgrade some bundled Windows libraries
ClosedPublic

Authored by Itms on Jul 6 2017, 11:36 PM.

Details

Summary

Upgrade enet to 1.3.13.
Upgrade zlib to 1.2.11.
Upgrade libpng to 1.6.29.
Upgrade libxml2 to 2.9.4.

Test Plan

Build in Debug and Release mode, run the tests and start a game in Release mode. One can run the tests and start a game in Debug mode but will encounter other bugs that are unrelated.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Itms created this revision.Jul 6 2017, 11:36 PM
Vulcan added a subscriber: Vulcan.Jul 7 2017, 1:35 AM
Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/294/ for more details.

Vulcan added a comment.Jul 7 2017, 3:08 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1708/ for more details.

Imarok accepted this revision.EditedJul 7 2017, 8:38 PM

Tested on win:

Compile in release mode
Compile in debug mode
Run tests in release mode
Run tests in debug mode (Expected)
Run game in release mode
Run game in debug mode
Played a MP game with @elexis

This revision is now accepted and ready to land.Jul 7 2017, 8:38 PM
Imarok added a subscriber: elexis.Jul 7 2017, 8:46 PM

You might want to update miniupnpc which is vulnerable to DoS.

fabio added a subscriber: fabio.Jul 8 2017, 9:00 AM

Any idea why enet dlls are so much bigger in size?

Itms added a comment.Jul 9 2017, 5:18 PM
In D718#28635, @leper wrote:

You might want to update miniupnpc which is vulnerable to DoS.

Going to do that in a new revision, hold on!

In D718#28672, @fabio wrote:

Any idea why enet dlls are so much bigger in size?

No I don't know. I didn't make the previous update(s) myself but I followed the instructions Ben left (which are consistent with the official docs).

This revision was automatically updated to reflect the committed changes.
elexis awarded a token.Jul 9 2017, 5:40 PM