Differential D718

Upgrade some bundled Windows libraries
ClosedPublic
Actions

Authored by Itms on Jul 6 2017, 11:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 13, 12:08 PM

	Unknown Object (File)
	Mon, Sep 9, 5:47 PM

	Unknown Object (File)
	Mon, Sep 9, 2:37 PM

	Unknown Object (File)
	Thu, Sep 5, 12:55 PM

	Unknown Object (File)
	Wed, Sep 4, 8:54 AM

	Unknown Object (File)
	Sun, Sep 1, 9:33 AM

	Unknown Object (File)
	Fri, Aug 30, 11:24 PM

Subscribers

Tokens

"Like" token, awarded by elexis.

Details

Reviewers

Commits

rP19895: Upgrade a few bundled Windows libraries, refs #3004.

Summary

Upgrade enet to 1.3.13.
Upgrade zlib to 1.2.11.
Upgrade libpng to 1.6.29.
Upgrade libxml2 to 2.9.4.

Test Plan

Build in Debug and Release mode, run the tests and start a game in Release mode. One can run the tests and start a game in Debug mode but will encounter other bugs that are unrelated.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Itms created this revision.Jul 6 2017, 11:36 PM

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/294/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1708/ for more details.

Harbormaster completed remote builds in B2530: Diff 2836.Jul 7 2017, 3:08 AM

Tested on win:

Compile in release mode
Compile in debug mode
Run tests in release mode
Run tests in debug mode (Expected)
Run game in release mode
Run game in debug mode
Played a MP game with @elexis

This revision is now accepted and ready to land.Jul 7 2017, 8:38 PM

Imarok added a subscriber: elexis.Jul 7 2017, 8:46 PM

You might want to update miniupnpc which is vulnerable to DoS.

Any idea why enet dlls are so much bigger in size?

In D718#28635, @leper wrote:

You might want to update miniupnpc which is vulnerable to DoS.

Going to do that in a new revision, hold on!

In D718#28672, @fabio wrote:

Any idea why enet dlls are so much bigger in size?

No I don't know. I didn't make the previous update(s) myself but I followed the instructions Ben left (which are consistent with the official docs).

Closed by commit rP19895: Upgrade a few bundled Windows libraries, refs #3004. (authored by Itms). · Explain WhyJul 9 2017, 5:38 PM

This revision was automatically updated to reflect the committed changes.

elexis awarded a token.Jul 9 2017, 5:40 PM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

system/

libraries/

win32/

enet/

include/

enet/

2 lines

lib/

libpng/

include/

387 lines

50 lines

7 lines

lib/

libxml2/

include/

libxml/

22 lines

4 lines

parserInternals.h

2 lines

schemasInternals.h

92 lines

2 lines

8 lines

8 lines

xpathInternals.h

2 lines

lib/

zlib/

include/

43 lines

452 lines

lib/

Diff 2876

ps/trunk/binaries/system/enet.dll

Loading...

ps/trunk/binaries/system/enetd.dll

Loading...

ps/trunk/binaries/system/libpng16.dll

Loading...

ps/trunk/binaries/system/libpng16d.dll

Loading...

ps/trunk/binaries/system/libxml2.dll

Loading...

ps/trunk/binaries/system/zlib1.dll

Loading...

ps/trunk/binaries/system/zlib1d.dll

Loading...

ps/trunk/libraries/win32/enet/include/enet/enet.h

Loading...

ps/trunk/libraries/win32/enet/lib/enet.lib

Loading...

ps/trunk/libraries/win32/enet/lib/enetd.lib

Loading...

ps/trunk/libraries/win32/libpng/include/png.h

Loading...

ps/trunk/libraries/win32/libpng/include/pngconf.h

Loading...

ps/trunk/libraries/win32/libpng/include/pnglibconf.h

Loading...

ps/trunk/libraries/win32/libpng/lib/libpng16.lib

Loading...

ps/trunk/libraries/win32/libpng/lib/libpng16d.lib

Loading...

ps/trunk/libraries/win32/libxml2/include/libxml/dict.h

Loading...

ps/trunk/libraries/win32/libxml2/include/libxml/parser.h

Loading...

ps/trunk/libraries/win32/libxml2/include/libxml/parserInternals.h

Loading...

ps/trunk/libraries/win32/libxml2/include/libxml/schemasInternals.h

Loading...

ps/trunk/libraries/win32/libxml2/include/libxml/xmlerror.h

Loading...

ps/trunk/libraries/win32/libxml2/include/libxml/xmlstring.h

Loading...

ps/trunk/libraries/win32/libxml2/include/libxml/xmlversion.h

Loading...

ps/trunk/libraries/win32/libxml2/include/libxml/xpathInternals.h

Loading...

ps/trunk/libraries/win32/libxml2/lib/libxml2.lib

Loading...

ps/trunk/libraries/win32/zlib/include/zconf.h

Loading...

ps/trunk/libraries/win32/zlib/include/zlib.h

Loading...

ps/trunk/libraries/win32/zlib/lib/zlib1.lib

Loading...

ps/trunk/libraries/win32/zlib/lib/zlib1d.lib

Loading...