Fix some style issues noticed by the linter. (Stripped apart from D717)
Details
Details
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- https://svn.wildfiregames.com/public/ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 2623 Build 4453: Vulcan Build (Windows) Jenkins Build 4452: Vulcan Build Jenkins Build 4451: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1711/ for more details.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/297/ for more details.
Comment Actions
Could also change some other files. Or not.
In D717 we also noticed that healers (or which unit was it?) include some stuff the parent template already has, should be cleaned up somewhere too.
binaries/data/mods/public/simulation/components/StatusBars.js | ||
---|---|---|
1 | Maybe a prototype property would look preferable (if that works with de/serialization) |
Comment Actions
(Oups, that acceptance is a leftover from when I first looked at this. Give bb those periods before committing)
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1756/ for more details.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/326/ for more details.