Page MenuHomeWildfire Games

StatusBar style cleanup
ClosedPublic

Authored by Imarok on Jul 7 2017, 2:18 PM.

Details

Summary

Fix some style issues noticed by the linter. (Stripped apart from D717)

Test Plan

functionality should not change.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
https://svn.wildfiregames.com/public/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2623
Build 4453: Vulcan Build (Windows)Jenkins
Build 4452: Vulcan BuildJenkins
Build 4451: arc lint + arc unit

Event Timeline

Imarok created this revision.Jul 7 2017, 2:18 PM
Vulcan added a subscriber: Vulcan.Jul 7 2017, 4:04 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1711/ for more details.

Vulcan added a comment.Jul 7 2017, 4:05 PM
Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/297/ for more details.

bb added a subscriber: bb.Jul 10 2017, 3:21 PM

patch nice and small so fix all issues found by bb linting too :P

binaries/data/mods/public/simulation/components/StatusBars.js
1

make it a g_FooBar

22–23

move opening tag a line up and fix the indentation of the block.

23–28

trailling comma

38

period

115

period

225

use capital letter

elexis accepted this revision.Jul 10 2017, 4:32 PM
elexis added a subscriber: elexis.

Could also change some other files. Or not.
In D717 we also noticed that healers (or which unit was it?) include some stuff the parent template already has, should be cleaned up somewhere too.

binaries/data/mods/public/simulation/components/StatusBars.js
1

Maybe a prototype property would look preferable (if that works with de/serialization)

This revision is now accepted and ready to land.Jul 10 2017, 4:32 PM

(Oups, that acceptance is a leftover from when I first looked at this. Give bb those periods before committing)

Imarok updated this revision to Diff 2930.Jul 21 2017, 10:04 PM
Imarok marked 6 inline comments as done.

Fix (nearly) all warnings from the bb linter…

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1756/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/326/ for more details.

This revision was automatically updated to reflect the committed changes.