Storehouses miraculously all have the same dimensions, and while some obstructions could be a tiny bit smaller I didn't think anything (besides Carthage) was worth changing.
Details
Details
- Reviewers
bb - Commits
- rP20225: Resize storehouse so obstructions matches visually
See that the Carthage storehouse looks okay.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
ptol storehouse has useless 8 height. Not sure if ptol should have 4*4 rubble, maybe just 3*3 is correct
| binaries/data/mods/public/simulation/templates/structures/cart_storehouse.xml | ||
|---|---|---|
| 5 ↗ | (On Diff #2873) | normal things have 8 not sure if conflicting |
Comment Actions
also celting storehouses seem to overlap a bit Hellenic also slightly but less
Maybe maur needs a check too
| binaries/data/mods/public/simulation/templates/structures/cart_storehouse.xml | ||
|---|---|---|
| 5 ↗ | (On Diff #3725) | random value since the height is fairly the same as the other buildings |
| binaries/data/mods/public/simulation/templates/structures/gaul_storehouse.xml | ||
| 7 ↗ | (On Diff #3725) | depth="17.0" looks better to me (smaller not possible, notice there are 2 actors with sorta different size) |
| binaries/data/mods/public/simulation/templates/structures/ptol_storehouse.xml | ||
| 10 ↗ | (On Diff #3725) | shouldn't that become a 4x4 rubble and foundation? |
| binaries/data/mods/public/simulation/templates/structures/gaul_storehouse.xml | ||
|---|---|---|
| 7 ↗ | (On Diff #3725) | (I knew houses had different actors but didn't realize this one did too.) |