Page MenuHomeWildfire Games

Change some occurrences of BroadcastMessage where an entity id is available to use PostMessage
ClosedPublic

Authored by echotangoecho on Jul 10 2017, 1:46 PM.

Details

Reviewers
elexis
mimo
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP20038: Change some occurrences of BroadcastMessage where an entity id is available to…
Summary

This should not affect any users of the MT_EntityRenamed, as all of them currently use OnGlobalEntityRenamed.

Test Plan

Verify the game still works correctly when entities are renamed.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

echotangoecho created this revision.Jul 10 2017, 1:46 PM
Vulcan added a subscriber: Vulcan.Jul 10 2017, 2:33 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1729/ for more details.

elexis added a reviewer: Restricted Owners Package.Jul 10 2017, 3:14 PM
elexis edited edge metadata.

Missing quotes and spaces

Add spaces and quotes.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1734/ for more details.

Did you search for things like OnGlobalEntityRenamed? Sometimes it's not only one entity that needs an update.

Yes, I did: all places where this message is subscribed to use OnGlobalEntityRenamed, so this shouldn't change any behavior.

mimo accepted this revision.Jul 12 2017, 6:13 PM
mimo added a subscriber: mimo.

Code looks good, and tested on a 4 AIs replay that it does not change the hash value.

This revision is now accepted and ready to land.Jul 12 2017, 6:13 PM
In D733#29081, @mimo wrote:

Code looks good, and tested on a 4 AIs replay that it does not change the hash value.

Are you going to commit this?

mimo added a comment.Aug 25 2017, 5:55 PM

yep, it slipped out of my mind.

This revision was automatically updated to reflect the committed changes.