Page MenuHomeWildfire Games

Mercenary technology fix
ClosedPublic

Authored by Grugnas on Jul 10 2017, 7:39 PM.

Details

Summary

as reported by borg- and Retardado, upgrade_rank_advanced_mercenary shouldn't affect Mercenary Champion units.

Test Plan

play a game to test.

(Unrelated:

(20:02:00) borg-: Grugnas: 
(20:02:47) borg-: play atens vs atens, if u up merc tech, happens the bug, and you can not train the mercenaries in the barracks anymore
(20:03:10) borg-: It is without cost values, only your photo, to click, but nothing happens
(20:07:49) borg-: and i have more one bug
(20:08:21) borg-: retardadosvn will show me later, cunobelin infinite aura
(20:08:33) borg-: i need togo now
(20:08:36) borg-: cya

Can be reproduced with current svn (19902).

That however is #4332)

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Grugnas created this revision.Jul 10 2017, 7:39 PM
Owners added a subscriber: Restricted Owners Package.Jul 10 2017, 7:39 PM
Vulcan added a subscriber: Vulcan.Jul 10 2017, 8:42 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1731/ for more details.

elexis edited the test plan for this revision. (Show Details)Jul 10 2017, 10:00 PM
elexis edited the test plan for this revision. (Show Details)Jul 11 2017, 12:02 AM
elexis accepted this revision.Jul 11 2017, 12:10 AM
elexis added a subscriber: elexis.

Thanks for the quick report and fix.

The patch is correct because tested (and because the Adanced units become trainable with that patch as seen in the line above).
Patch complete because upgrade_mace_silvershields.json only has one effect and no other technology messed with Promotion.

Offtopic, but we should probably delete those:

upgrade_rank_advanced_celts.json
upgrade_rank_advanced_iberian.json
upgrade_rank_advanced_italiote.json
upgrade_rank_elite_celts.json
upgrade_rank_elite_iberian.json
upgrade_rank_elite_italiote.json
upgrade_rank_advanced_cavalry.json
upgrade_rank_advanced_infantry.json
upgrade_rank_advanced_mercenary.json
upgrade_rank_elite_cavalry.json
upgrade_rank_elite_infantry.json
This revision is now accepted and ready to land.Jul 11 2017, 12:10 AM

Technically the tech still did what the string said. We should change the string after the release!

This revision was automatically updated to reflect the committed changes.