Differential D738

Pass a const reference, if someone wants to modify it they should use the global directly.
ClosedPublic
Actions

Authored by • leper on Jul 12 2017, 11:30 PM.

Details

Reviewers

vladislavbelov

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP20027: Pass a const reference, if someone wants to modify it they should use the…

Test Plan

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

• leper created this revision.Jul 12 2017, 11:30 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1735/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/308/ for more details.

Harbormaster completed remote builds in B2593: Diff 2897.Jul 13 2017, 12:21 AM