Page MenuHomeWildfire Games

Remove commented out code.
ClosedPublic

Authored by leper on Jul 12 2017, 11:54 PM.

Details

Reviewers
Sandarac
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP19932: Remove commented out code.
Test Plan

Apply life-long training to spot the commented out code.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

leper created this revision.Jul 12 2017, 11:54 PM
Owners added a subscriber: Restricted Owners Package.Jul 12 2017, 11:54 PM
Vulcan added a subscriber: Vulcan.Jul 13 2017, 2:55 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1739/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/312/ for more details.

elexis added a subscriber: elexis.Jul 13 2017, 11:54 AM

GameView.cpp:869

(Maybe someone can figure out some way to detect commented out code automatically)

Sandarac accepted this revision.Jul 14 2017, 10:26 AM
In D742#29187, @elexis wrote:

GameView.cpp:869

One could argue that GameView.cpp is not MapReader.cpp.

This revision is now accepted and ready to land.Jul 14 2017, 10:26 AM
This revision was automatically updated to reflect the committed changes.