Details

Reviewers

Imarok
mimo
elexis

Commits

rP19928: Take gui.scale into account when repositioning tooltips

Test Plan

To reproduce add:

gui.scale = "1.8"

into your user.cfg, then open 0A.D., go to 'Learn to play' -> 'Structure Tree' and hold the mouse over an icon on the right-hand side of the screen. The tooltip is not repositioning at all. (this is also true during actual gameplay itself)

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joskar created this revision.Jul 17 2017, 3:04 PM

Added my name to programming.json

Maybe nicer to read if the last line is split.
The explicit conversion is not needed, is it?

Removed explicit conversion.
Declarations on separate lines.

Remove accidentally added *.swp file

Works as intended.
Code looks also good.
(Will commit it when commit freeze is over)

This revision is now accepted and ready to land.Jul 17 2017, 7:07 PM

elexis mentioned this in D332: Add an option in the Options menu to change the UI scale.Jul 23 2017, 6:45 PM

Closed by commit rP19928: Take gui.scale into account when repositioning tooltips (authored by Imarok). · Explain WhyJul 29 2017, 8:31 PM

This revision was automatically updated to reflect the committed changes.

Take gui.scale into account when repositioning tooltips
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 2954

ps/trunk/binaries/data/mods/public/gui/credits/texts/programming.json

ps/trunk/source/gui/CTooltip.cpp

Take gui.scale into account when repositioning tooltipsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2954

ps/trunk/binaries/data/mods/public/gui/credits/texts/programming.json

ps/trunk/source/gui/CTooltip.cpp

Take gui.scale into account when repositioning tooltips
ClosedPublic
Actions

Revision Contents
Changeset List