Differential D751

Fix AI error in ApplyEntitiesDelta()
ClosedPublic
Actions

Authored by Sandarac on Jul 22 2017, 7:59 AM.

Details

Reviewers

mimo

Commits

rP19945: Fix AI error in ApplyEntitiesDelta()

Summary

From https://wildfiregames.com/forum/index.php?/topic/22650-alpha-22-resourcesupplytype-is-undefined/

In some rare cases, the loop on events.TrainingFinished may include entities that have already been destroyed, and then pass undefined to setMetadata (there is already this check in the loops on f.e. ConstructionFinished and ChangedEntityTemplateInfo).

Test Plan

Read the code, run the commands.txt from the forum post to see that errors don't occur anymore.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Sandarac created this revision.Jul 22 2017, 7:59 AM

Owners added a subscriber: Restricted Owners Package.Jul 22 2017, 7:59 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1758/ for more details.

Harbormaster completed remote builds in B2625: Diff 2932.Jul 22 2017, 8:46 AM

nice catch

This revision is now accepted and ready to land.Aug 5 2017, 7:24 PM

Closed by commit rP19945: Fix AI error in ApplyEntitiesDelta() (authored by mimo). · Explain WhyAug 5 2017, 7:28 PM

This revision was automatically updated to reflect the committed changes.