Differential D751
Fix AI error in ApplyEntitiesDelta() Authored by Sandarac on Jul 22 2017, 7:59 AM.
Details
From https://wildfiregames.com/forum/index.php?/topic/22650-alpha-22-resourcesupplytype-is-undefined/ In some rare cases, the loop on events.TrainingFinished may include entities that have already been destroyed, and then pass undefined to setMetadata (there is already this check in the loops on f.e. ConstructionFinished and ChangedEntityTemplateInfo). Read the code, run the commands.txt from the forum post to see that errors don't occur anymore.
Diff Detail
Event TimelineComment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files... http://jw:8080/job/phabricator/1758/ for more details. |