Currently we have 5 relics by default which is only interesting when wanting to hunt them for bonuses.
The default should be 1 or 2 so that it's likely to get the relic victory started (which is something the players expect from the gamemode).
Details
Details
Read the string.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1795/ for more details.
Comment Actions
Executing section Default...
Executing section Source...
Executing section JS...
| | [NORMAL] ESLintBear (no-undef-init):
| | It's not necessary to initialize 'g_GameStanzaTimer' to undefined.
|----| | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/gamesetup/gamesetup.js
| |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/gamesetup/gamesetup.js
| 318| 318| /**
| 319| 319| * Index of the GUI timer.
| 320| 320| */
| 321| |-var g_GameStanzaTimer = undefined;
| | 321|+var g_GameStanzaTimer;
| 322| 322|
| 323| 323| /**
| 324| 324| * Only send a lobby update if something actually changed.
| | [NORMAL] ESLintBear (no-undef-init):
| | It's not necessary to initialize 'yPos' to undefined.
|----| | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/gamesetup/gamesetup.js
| |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/gamesetup/gamesetup.js
|1144|1144|
|1145|1145| function verticallyDistributeGUIObjects(parent, objectHeight, ignore)
|1146|1146| {
|1147| |- let yPos = undefined;
| |1147|+ let yPos;
|1148|1148|
|1149|1149| let parentObject = Engine.GetGUIObjectByName(parent);
|1150|1150| for (let child of parentObject.children)
binaries/data/mods/public/gui/gamesetup/gamesetup.js
| 695| » » » let·pData·=·playerData.find(pData·=>·sameColor(g_PlayerColorPickerList[selectedIdx],·pData.Color));
| | [NORMAL] ESLintBear (no-shadow):
| | 'pData' is already declared in the upper scope.
binaries/data/mods/public/gui/gamesetup/gamesetup.js
|1600| » while·(g_IsNetworked)
| | [NORMAL] ESLintBear (no-unmodified-loop-condition):
| | 'g_IsNetworked' is not modified in this loop.
binaries/data/mods/public/gui/gamesetup/gamesetup.js
|2050| » » for·(let·guid·in·g_PlayerAssignments)
| | [NORMAL] ESLintBear (no-shadow):
| | 'guid' is already declared in the upper scope.
binaries/data/mods/public/gui/gamesetup/gamesetup.js
|2050| » » for·(let·guid·in·g_PlayerAssignments)
| | [NORMAL] ESLintBear (no-shadow):
| | 'guid' is already declared in the upper scope.
binaries/data/mods/public/gui/gamesetup/gamesetup.js
| 321| var·g_GameStanzaTimer·=·undefined;
| | [NORMAL] JSHintBear:
| | It's not necessary to initialize 'g_GameStanzaTimer' to 'undefined'.
binaries/data/mods/public/gui/gamesetup/gamesetup.js
| 946| » g_IsTutorial·=·attribs.tutorial·&&·attribs.tutorial·==·true;
| | [NORMAL] JSHintBear:
| | Use '===' to compare with 'true'.
binaries/data/mods/public/gui/gamesetup/gamesetup.js
|1147| » let·yPos·=·undefined;
| | [NORMAL] JSHintBear:
| | It's not necessary to initialize 'yPos' to 'undefined'.
binaries/data/mods/public/gui/gamesetup/gamesetup.js
|1582| » if·(g_LoadingState·==·0)
| | [NORMAL] JSHintBear:
| | Use '===' to compare with '0'.
binaries/data/mods/public/gui/gamesetup/gamesetup.js
|1634| » » if·(playerData.some((pData,·j)·=>·i·!=·j·&&·sameColor(playerData[i].Color,·pData.Color)))
| | [NORMAL] JSHintBear:
| | Don't make functions within a loop.
binaries/data/mods/public/gui/gamesetup/gamesetup.js
|1635| » » » playerData[i].Color·=·g_PlayerColorPickerList.find(color·=>·playerData.every(pData·=>·!sameColor(color,·pData.Color)));
| | [NORMAL] JSHintBear:
| | Don't make functions within a loop.
binaries/data/mods/public/gui/gamesetup/gamesetup.js
|1812| » » » chosenCiv·=·pickRandom(Object.keys(g_CivData).filter(civ·=>·g_CivData[civ].Culture·==·culture));
| | [NORMAL] JSHintBear:
| | Don't make functions within a loop.
binaries/data/mods/public/gui/gamesetup/gamesetup.js
|1826| » » let·usedName·=·g_GameAttributes.settings.PlayerData.filter(pData·=>·pData.Name·&&·pData.Name.indexOf(chosenName)·!==·-1).length;
| | [NORMAL] JSHintBear:
| | Don't make functions within a loop.
binaries/data/mods/public/gui/gamesetup/gamesetup.js
|2262| » if·(g_GameStanzaTimer·!=·undefined)
| | [NORMAL] JSHintBear:
| | Use '!==' to compare with 'undefined'.
binaries/data/mods/public/gui/gamesetup/gamesetup.js
|2302| » if·(g_GameStanzaTimer·!=·undefined)
| | [NORMAL] JSHintBear:
| | Use '!==' to compare with 'undefined'.
Executing section XML GUI...
Executing section Python...
Executing section Perl...http://jw:8080/job/phabricator_lint/351/ for more details.