Page MenuHomeWildfire Games

Scythian Archer has no capture animation
ClosedPublic

Authored by Stan on Aug 8 2017, 10:08 AM.

Details

Reviewers
Imarok
enrique
fatherbushido
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP19964: Scythian Archer has no capture animation
Trac Tickets
#4711
Summary

See ticket. This patch cleans the actor by removing the useless anims, and adds the capture animation as it is used by other archers.

Test Plan

Checks if everything works correctly

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Stan created this revision.Aug 8 2017, 10:08 AM
Vulcan added a subscriber: Vulcan.Aug 8 2017, 10:08 AM

Build has FAILED

Link to build: http://jw:8080/job/phabricator/1804/
See console output for more information: http://jw:8080/job/phabricator/1804/console

Stan edited the summary of this revision. (Show Details)Aug 8 2017, 10:09 AM
Stan updated this revision to Diff 3028.Aug 8 2017, 10:12 AM

I always forget Phabricator doesn't have ps trunk prefix...

Build has FAILED

Link to build: http://jw:8080/job/phabricator/1805/
See console output for more information: http://jw:8080/job/phabricator/1805/console

Stan updated this revision to Diff 3029.Aug 8 2017, 10:12 AM

Build has FAILED

Link to build: http://jw:8080/job/phabricator/1806/
See console output for more information: http://jw:8080/job/phabricator/1806/console

Stan updated this revision to Diff 3030.Aug 8 2017, 10:13 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1807/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1808/ for more details.

Imarok accepted this revision.EditedAug 8 2017, 1:39 PM

Works, seems to be correct, and looks complete at a quick glance.
Thank you for looking into such issues ;)

This revision is now accepted and ready to land.Aug 8 2017, 1:39 PM
This revision was automatically updated to reflect the committed changes.