Units and Buildings totals are on the left. To make it consistent, the resource totals should also be on the left side.
Details
Details
- Reviewers
bb - Commits
- rP19970: [Summary] Move the resource total to the left
Check that resources(gathered & used) and their totals and team totals are displayed correctly in the Resource tab and the charts.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1825/ for more details.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... binaries/data/mods/public/gui/summary/layout.js | 283| » » if·(rowPlayerObjectWidth·==·0) | | [NORMAL] JSHintBear: | | Use '===' to compare with '0'. Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/369/ for more details.
Comment Actions
totals correctly displayed, only once the values have 5 or more digits (which is not unlikely to happen) they will collide with the civ icon (strictly that was already the case only this makes the chance bigger since total > food mostly), but as there are more of such cases => out of scope